New Code Macro

The examples for the new code macro really look nice, but:

It seems as if unlike the old code macro the rendered result is not put into divs. This will break the layout of many old pages. E. g. the following code:

# Here my code:
{code:none|title=somefile.txt}
XYZ
{code}

will not be rendered anymore with the code-panel beeing on a second line but rather with a textfield just behind "code:" with the bottom line of the field aligned with the bottom line of the text.

Please at least find a way to make legacy markup look nice. Otherwise enabling this plugin will surely break many carefully designed layouts.

I completely agree with Mark above.

I like many of the new features of the "New Code Macro", but have reservations as to the lacking of features the original Code Macro included. For this reason I also wonder if the two can co-exist somehow.

In my opinion, the feature that is lacking is the ability to include a title. This is very useful for documenting contents of files for example.

The following code useable by the original, no longer works:

# Here my code:
{code:none|title=somefile.txt}
XYZ
{code}

The result is as follows:

XYZ

Here's a very basic Cisco config highlighter

dp.sh.Brushes.Cisco = function()
{
	//
	// 2006 by Andrew J Cosgriff, based on emacs font-lock keywords at http://www.emacswiki.org/cgi-bin/wiki/cisco-router-mode.el
	//
	var toplevel_keywords =	'access-list class-map controller crypto interface policy-map redundancy route-map router username';
	var command_keywords = 'alias boot card diagnostic ^enable hostname logging service snmp-server version vtp';

	this.regexList = [
		{ regex: new RegExp('^!.*$', 'gm'),							css: 'comment' },			//  comments
		{ regex: new RegExp('[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+', 'g'),				css: 'vars' },			// IP addresses
		{ regex: new RegExp('no ', 'gm'),						css: 'preprocessor' },		// "no" something
		{ regex: new RegExp(this.GetKeywords(toplevel_keywords), 'gm'),		css: 'keyword' },	// cisco toplevel keywords
		{ regex: new RegExp(this.GetKeywords(command_keywords), 'gm'),		css: 'keyword' }		// cisco command keywords
		];

	this.CssClass = 'dp-c';
}

dp.sh.Brushes.Cisco.prototype	= new dp.sh.Highlighter();
dp.sh.Brushes.Cisco.Aliases	= ['cisco'];

Note: this macro cannot be exported to PDF. This is a known bug, please use the original code macro if exports are required.

Agnes.

Nifty macro!

The only drawback is: Long pieces of code do not work well with the macro. The browser pops up a warning:

Unable to render embedded object: File (unresponsive script.jpg) not found.

If you click continue, the browser might show the code in the macro. If the code is really long, it takes ages and many continue-clicks.

Would be awesome if you could fix that problem!

Cheers
Thomas

We tries out v1.3 and it but the Rich Text editor lost all the carrage returns in the code, making it hard to edit. (WikiMarkup was fine - but not if you looked at the Rich Text first and then clicked on wiki markup)

Thomas, that unresponsive script warning seems to be a bug with the way Firefox runs the javascript.  It seems to work fine in IE.  We've had to install IE Tab extension in firefox in order to use this, until the author can resolve this issue.

Oh ok.. Weird.. I stand corrected.  Seems to work fine for us in IE though.

I found that when I first inserted the new code macro and a code sample on a page and saved it, the code was displayed nicely. However, when I returned to edit the page, and viewed the Wiki markup and saved the page again, the code collapsed i.e. the line breaks were removed. Atlassian Support has recognised the problem and raised a bug: http://jira.atlassian.com/browse/CONF-6826

Please vote for this issue to get it fixed.

I've done a bit more work on the Cisco syntax highlighting.

a diff against 1.0.3 and a jar file are available via http://polydistortion.net/monkey/archives/2006/09/10/003819.html

It would be super-useful to have a "wiki" language file for the syntax highlighter - there's loads of times when I've had to show chunks of wiki notation in user guides, etc., and having a wiki syntax would be a dream

Hi,

the plugin is great, but it would be even better if it would be possible to display attached source files. Also a line range and not just a start would be great.

If you expand a collapsed code fragment it should be possible to collapse them again.

Best

Thomas

This would be a fantastic boon for my developers, but I'm concerned about using it until it's really stable. I think I'm going to go as far as to hold off until this moves from "New Code Macro" to "Standard Code Macro". When Atlassian trusts it enough to have it enabled, so will I.

I just added a vote for fixing the bug that makes the RTF mode mess up code formatting. My team can't use this until that's fixed. Awesome macro though!

Does anyone know if the issue with the rich test editor removing all the line breaks in code snippets has been resolved? Is there a work-around? This is an extremely, even fatal, problem for many of my existing pages.public void testThis {
private static aTest;
}
Hm...looks like there's still a problem here, just a different one.

Because of its unpredictable results and the loss of some features (title, borderStyle, bgColor) the plugin should better not replace the original {code} macro. You can easily change the macros name by editing the atlassian-plugin.xml file within newcode-macro-plugin-1.0.3.jar.

After that, the macros name will be {newcode} and you can keep on using {code}.

Hint for Windows Users: a jar is nothing else than a zip file, simply rename .jar to .zip and open it with windows explorer, rename it back to .jar before uploading it.

Hi, I am having a problem using the New Code Macro on IE 7.0.  If I have one long line of text within the {code} tags the macro produces a scrollbar at the bottom of the code box but it covers up the single line of text. I am currently using IE 7.0 to enter this comment and when I shrink the width of the browser the scroll bar pops up over the text on the example below.

This is some text that could cause a horizantal scroll bar with a narrow enough window

With the window wide enough the scroll bar goes away and the text can be seen.

Is this a bug that is known and is in the process of being fixed? I looked for the source code to take a look at it here but there doesn't seem to be any to download.

We have 2.8 installed and are trying to use C# with the code macro.

I notice it is one of the supported languages, but come up with an error.

Available languages are: actionscript, html, java, javascript, none, sql, xhtml, xml

Please help.

Thanks,

Crystal Johnson

I found these two issues when using the new code macro:

• Highlightning for Python seems pretty poor.
• the code inside the macro is messed up whenever you edit the page.

Can we expect any improvements for this macro ?

I have some issues getting firstline to work.
I use {NewCode:powershell|theme=rdark|firstline=33} but it always starts counting from 01

also a strong urge to leave the default {code} intact. If the new code macro keeps this name {NewCode} we don't have to disable the builtin {code} macro.

And some remark about this page: the ruler is by default False, which is Ok. This page says incorrect it is True by default.

PS. Where do you want my PowerShell formatter to be uploaded, or shall I send it by mail?

(Filed in Jira: Description, in the Jira NCODE-9 .)

When used with the {toc} macro on same page, and you click Save in the edit window, the first display of the page shrinks the code window.

{toc}

{code:python}
# A tall but trivial code block.
# Consisting of nothing but a few lines of comments.
#
#
#
#
#
#
#
#
# End of code block
{code} 

Renders as:

I have disabled the Code Macro plugin and installed the jar package in the Plugins Manager and it states it is enabled. But when I go to any page with a {code} macro I get this error:

Unknown macro: {code}

I can enable the Code Macro plugin and it all works with standard {code} but I really want the csharp formatting!

I am using Confluence 2.10 and have this set up in a Dev Environment so can try a few things if required to debug....

Nice replacement for the code macro, but like others have noted it has it's bugs. Firstline doesn't work and since it doesn't I would suggest removing it as a viable parameter until it is fixed. I wasted 1/2 an hour trying to see what was wrong with my code before Is aw that there is a known bug.

Also, I wonder why one of the languages isn't wiki/textile/velocity. Seems ironic that the native languages are omitted.

As someone else observed the notation guide doe not have this macro at least in 2.10.

One final note, I noticed that the controls tend to obscure the text underneath them rather then rendering a wider box to allow for both the code and the controls.

I tried installing 1.9.1, but I get an error:

Error: There was a problem loading the descriptor for module 'code' in plugin 'New Code Macro Plugin'. Error retrieving dependency of class: com.atlassian.confluence.ext.code.NewCodeMacro. Missing class: org/lobobrowser/html/parser/InputSourceImpl

I have disabled the Code plug-in...gone back to 1.9.0 for now.

I see that you are planning on fixing the PDF export bug in 1.9.2. Do you have an estimate when that will be released? We really can't use this shiny new plugin until it works with PDF.

Hi,

i like this Macro but when using the {code}
makro the old highligther for "none" does not work anymore. So I tried to add a new language us descripted above, actually I used a copy of plain and modified it, to bring back the none-brush. Still same problem when I open up a page with {code:none} the brush "none" is missing. How can I fix this?
Oliver

We have a problem with the xml brush file. A bug has been opened at the bug tracking tool of the SyntaxHighlighter web site.

The problem is that semicolon are appearing within the closing element tag when a URL is the element content.

For instance, using the code macro with the xml brush for the following:

<some_element>http://my.website.com/</some_element>

would produce:

<some_element>http://my.website.com/<;/some_element>

Notice the semicolon in the closing some_element tag. If you put a space between the content and the closing tag, the semicolon does not appear. If you use one / in the URL instead of two, no problem either. Since using URL is pretty common within XML, this problem is causing us some trouble. We are using version 1.9.2. which otherwise is a great replacement for the default code macro from Atlassian. Great job!

Thanks

Stephane