Diff view may hide some changes in the Pull Request

Still need help?

The Atlassian Community is here for you.

Ask the community


Platform notice: Server and Data Center only. This article only applies to Atlassian products on the Server and Data Center platforms.

Support for Server* products ended on February 15th 2024. If you are running a Server product, you can visit the Atlassian Server end of support announcement to review your migration options.

*Except Fisheye and Crucible





Problem

In a Pull Request that includes many changes in a file (e.g., 200+ lines changed), using the Find function of the Diff view may hide several last lines that have changed.
For example:

  1. Create a Pull Request where 200 lines have been added to a file

  2. Open the Pull Request and switch to the Diff view

  3. Scroll all the way down and note that all 200 added lines are shown

  4. Click on one of the green lines, then use Ctrl+F (or Command+F) to display the Find: field

  5. Type some search string in the Find field (e.g., Test) and click the Next match and Previous match buttons several times

  6. Scroll all the way down and note that a few last lines are no longer shown

    (in some cases you may need to scroll up and down a few times before the problem occurs)

As result, reviewers may not see some of the suggested changes in the Pull Request, and merge or reject the Pull Request without a complete code review.

Diagnosis

Environment

  • This issue has been reproduced against several versions of Bitbucket Server, using Firefox versions 69 and 70 on Ubuntu Linux 18.04 and on Mac OS X 10.14.6.

  • The problem did not occur in a Pull Request with 160 lines of text (or fewer) have been changed.

Cause

This has been raised as a Bitbucket Server bug  BSERV-11000 - Getting issue details... STATUS

Workaround


Resizing the browser window, or re-entering the Pull Request, should show the entire Diff again.
However, the reviewers may not always realise that they are missing some lines.





Last modified on Oct 30, 2019

Was this helpful?

Yes
No
Provide feedback about this article
Powered by Confluence and Scroll Viewport.