CheckStyle Plugin

This look like just what we need, but I can't get it to pick up the checkstyle results. The project I'm using to test the plugin has ten checkstyle errors, but the graphs generated show zero errors. I'm pointing the plug in to the checkstyle-result.xml file (**/target/checkstyle-result.xml) is this the correct file?.

the graph seems sometimes to show false values.
I reduced in a project the violations from about 50.000 to about 7, and the graph shows 450000.

Is it possible to add value that displays the something like a rating ( violations / source code lines).

Thanks in advance

Hi, i found a small bug:

If there are no 10 violations in the file the plugin crashes: 

 2007-10-18 12:59:20,859 ERROR [BAM:Default Queue:BuildExe] [CheckStyleBuildProcessor] Failed to parse artifact result file "checkstyle_errors.xml"
java.lang.IndexOutOfBoundsException: Index: 8, Size: 8                                                              
   at java.util.ArrayList.RangeCheck(ArrayList.java:546)                                                              
   at java.util.ArrayList.get(ArrayList.java:321)                                                              
   at com.atlassian.bamboo.plugins.checkstyle.CheckStyleReportParser.convertTopViolationsToCsv(CheckStyleReportParser.java:127)                             
   at com.atlassian.bamboo.plugins.checkstyle.CheckStyleBuildProcessor$CheckStyleFileVisitor.runParse(CheckStyleBuildProcessor.java:132)                    
   at com.atlassian.bamboo.plugins.checkstyle.CheckStyleBuildProcessor$CheckStyleFileVisitor.visitFile(CheckStyleBuildProcessor.java:121)                   
   at com.atlassian.bamboo.utils.FileVisitor.visitAlLFilesThatMatchAPattern(FileVisitor.java:78)                                                            
   at com.atlassian.bamboo.utils.FileVisitor.visitFilesThatMatch(FileVisitor.java:52)                                                              
   at com.atlassian.bamboo.plugins.checkstyle.CheckStyleBuildProcessor.run(CheckStyleBuildProcessor.java:77)                                                
   at com.atlassian.bamboo.build.pipeline.tasks.ExecuteBuildTask.performCustomBuildProcess(ExecuteBuildTask.java:97)                                        
   at com.atlassian.bamboo.build.pipeline.tasks.ExecuteBuildTask.call(ExecuteBuildTask.java:50)                                                             
   at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176)                                                              
   at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:987)                                              
   at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:528)                                             
   at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$1.run(NamedThreadFactory.java:31)                                                   
   at edu.emory.mathcs.backport.java.util.concurrent.helpers.ThreadHelpers$1.run(ThreadHelpers.java:34)                                                     
   at java.lang.Thread.run(Thread.java:595)

Don't know where to post this bug, but there are issues (NumberFormatException), when you try to generate statistics, while the checkstyle plugin is active. (Unfortunately this effects all statistics - not only the checkstyle statistics).

These only happen under (for instance) a german locale.

To fix go to CheckstyleIndexReader.addBuildToSummary(..) and change the line:

double violations = Double.parseDouble(s);

to

double violations = NumberUtils.stringToDouble(s);

This is needed because in the PostBuildIndexWriter the NumberUtils.padWithZeros(..)-method is used, which respects the current locale (and generates strings like "000001234,00"). A simple Double.parse() thus is not enough.

Hi all,
sorry for the delay, but I've just fixed the 2 reported bugs.
Cheers

The aggregated per plan data is inaccurate. We have a multi-module project that results in 10 individual checkstyle.xml report files being generated by checkstyle itself as part of the build, of which there were at least 500+ warning and 1000+ info level violations. However the plugin reports 0 warnings, 0 info. I have not as yet delved into the code but i presume the plugin's functional tests cover converging/aggregating executions?.

Note the bamboo log file shows that the plugin processed each file so our glob wasnt incorrect.

Stephan, Is there anyway you could add a table below the graph showing the number of checkstyles for each build that showed what the actual checkstyle errors are ? It is kind of hard to tell what to fix just from looking at the top violators. Or does this capability already exist somewhere in the plugin ?

I'm finding two problems with the way this plugin is working:

• It seems to require a path to the results file itself, not to the directory it is in. Like some of the comments above, I can get it to work if I use **/target/checkstyle-result.xml, but not if I use **/target or **/target/* or **/target/*.xml.
• It does not seem to aggregate the data from Maven multi-module builds, but rather takes the checkstyle-result.xml from that last module in the chain.

We are running Bamboo 1.2.4, with Maven 2.0.8, and our project set up as multiple Maven modules.

Thanks for any hints,
John

Hi Paulick!

is any update scheduled to support Bamboo v2???

Thanks in advance,

Fernando

Also interested in a Bamboo 2 compatible plugin with the issues regarding the non aggregation of maven multi module builds resolved, is this planned?

We also need a working version for Bamboo 2 ... anyone working on it?

I am currently using Bamboo 2 when i try using the checkstyle(bamboo-checkstyle-plugin-1.0.1.jar )Plugin ,it seems checkstyle doesnt works with the bamboo 2 .Can you give me some suggestion to get checkstyle working with bamboo2 !!!

Hi all,

I posted a Bamboo 2.0 snapshot version of this plugin : bamboo-checkstyle-plugin-2.0-RC1-SNAPSHOT.jar
I'm testing it this week and I'm thinking release it the next week.

Good testing

I see a change history for 2.0, but the download link still points at 2.0-beta1

Is there a 2.0 jar available?